Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"


Copy link to this message
-
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter tests to repo"


> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java, lines 208-209
> > <https://reviews.apache.org/r/10987/diff/6/?file=304180#file304180line208>
> >
> >     The SQOOP_HOME variable is not defined by default when running tests. I would advise to use some test specific java property, there is many of them already defined or we can define new one if needed
> >    
> >     The test properties are created in the build.xml file here:
> >    
> >     https://github.com/apache/sqoop/blob/branch-1.4.0/build.xml#L596

Create "test.data.dir" system property in build.xml to point to the folder which contain the test data
> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > testdata/MSTest.properties, lines 1-40
> > <https://reviews.apache.org/r/10987/diff/6/?file=304196#file304196line1>
> >
> >     The usual workflow on jenkins is to check out the repository and set all required variables and/or properties for running the tests. It's completely fine to store defaults into file, however we have to be able to override all properties during ant execution, e.g something like:
> >    
> >     ant clean test -Dms.db.server.name=new_host
> >    
> >     It seems to me that this is not possible with current infrastructure, right? I'm afraid that changing checkout file is not feasible.

remove MSTest.properties file and define ms.sqlserver.username and ms.sqlserver.password in build.xml which can be passed as through ant command. Also since the servername is contained in "sqoop.test.sqlserver.connectstring.host_url", it can also passed through command line.
"ant test -Dmanual=true "-Dsqoop.test.sqlserver.connectstring.host_url=jdbc:sqlserver://MYSERVERNAME" "-Dms.sqlserver.username=MYUSERNAME" "-Dms.sqlserver.password=MYPASSWORD"" command like this should be able to run sqlserver test in jenkins
> On June 15, 2013, 5:41 p.m., Jarek Cecho wrote:
> > testdata/MSTest.properties, line 22
> > <https://reviews.apache.org/r/10987/diff/6/?file=304196#file304196line22>
> >
> >     Is there a reason why are not reusing the property sqoop.test.sqlserver.connectstring.host_url that is already used in existing SQL Server tests? I would prefer to have one single property for all tests for one single db vendor.

Sorry missed it in the last patch. Fixed in the latest version
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21940
-----------------------------------------------------------
On June 18, 2013, 8:57 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:57 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
>     https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
>   build.xml ffc878e
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad
>   src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
>   src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION