Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> Extensions for patches accepted by QA bot


Copy link to this message
-
Re: Extensions for patches accepted by QA bot
Thanks Ted!
On Thu, Dec 5, 2013 at 8:50 AM, Ted Yu <[EMAIL PROTECTED]> wrote:

> Alright.
> Plan to stick with previous consensus of 3 file extensions.
>
> Cheers
>
>
> On Wed, Dec 4, 2013 at 9:07 AM, Nick Dimiduk <[EMAIL PROTECTED]> wrote:
>
> > I don't think that's a necessary filter; it'll still get false-positives
> > like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> > understanding in accepting and evaluating community contributions :)
> > Running failing to apply a non-patch doesn't really hurt anything.
> >
> >
> > On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
> >
> > > Over in HBASE-10017, the following attachment triggered a QA warning:
> > >
> > >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> > >
> > > Should the acceptance criteria include the notion that there should be
> > JIRA
> > > number in the filename ?
> > >
> > > Thanks
> > >
> > >
> > > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <[EMAIL PROTECTED]>
> > wrote:
> > >
> > > > +1 for .patch, .txt, .diff
> > > >
> > > > -Anoop-
> > > >
> > > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <[EMAIL PROTECTED]>
> > wrote:
> > > >
> > > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > > >
> > > > >
> > > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <[EMAIL PROTECTED]>
> wrote:
> > > > >
> > > > > > During review of
> > > > > >   HBASE-10044 test-patch.sh should filter out documents by known
> > file
> > > > > > extensions
> > > > > > Jesse made the suggestion that QA bot only accepts files with
> > > > extensions
> > > > > > .patch
> > > > > > and .txt
> > > > > >
> > > > > > I want to get opinion from the community on this matter.
> > > > > >
> > > > > > Thanks
> > > > > >
> > > > >
> > > >
> > >
> >
>
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB