Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 15635: SQOOP-1234 Sqoop2: Clean up comments in MSubmission class


Copy link to this message
-
Re: Review Request 15635: SQOOP-1234 Sqoop2: Clean up comments in MSubmission class
Abraham Elmahrek 2013-11-18, 13:12

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15635/#review29038
-----------------------------------------------------------
Thanks Jarcec for making the code base more readable! I've made a few comments with regards to grammar... but looks good to me otherwise.
common/src/main/java/org/apache/sqoop/model/MSubmission.java
<https://reviews.apache.org/r/15635/#comment56118>

    Missing a few articles: "This property holds the progress of the external process that is executing the Sqoop 2 job."...

common/src/main/java/org/apache/sqoop/model/MSubmission.java
<https://reviews.apache.org/r/15635/#comment56119>

    "during initialization and submission"

common/src/main/java/org/apache/sqoop/model/MSubmission.java
<https://reviews.apache.org/r/15635/#comment56120>

    "after the submission succeeds."

common/src/main/java/org/apache/sqoop/model/MSubmission.java
<https://reviews.apache.org/r/15635/#comment56121>

    "report progress at the required granularity"
- Abraham Elmahrek
On Nov. 18, 2013, 1:53 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15635/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 1:53 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1234
>     https://issues.apache.org/jira/browse/SQOOP-1234
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've updated the comments and fixed unused creation date.
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/sqoop/model/MSubmission.java a126d40
>
> Diff: https://reviews.apache.org/r/15635/diff/
>
>
> Testing
> -------
>
> This patch is introducing (almost) no code change, thus there are no new unit tests. The existing are passing though.
>
>
> Thanks,
>
> Jarek Cecho
>
>