Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request 14454: FLUME-2202. AsyncHBaseSink should coalesce increments to reduce RPC roundtrips


+
Hari Shreedharan 2013-10-02, 23:01
+
Hari Shreedharan 2013-10-03, 05:32
+
Hari Shreedharan 2013-10-03, 20:07
+
Mike Percy 2013-10-04, 00:25
+
Mike Percy 2013-10-03, 06:34
Copy link to this message
-
Re: Review Request 14454: FLUME-2202. AsyncHBaseSink should coalesce increments to reduce RPC roundtrips


> On Oct. 3, 2013, 6:34 a.m., Mike Percy wrote:
> > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java, line 287
> > <https://reviews.apache.org/r/14454/diff/1/?file=360743#file360743line287>
> >
> >     I wonder if this could be broken into 2 or 3 functions in order to be easier to follow. If not easy to do that it's not a big deal.

The whole test file needs some refactoring - there is quite a bit of repeated code. I will file a follow up for this.
> On Oct. 3, 2013, 6:34 a.m., Mike Percy wrote:
> > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java, line 298
> > <https://reviews.apache.org/r/14454/diff/1/?file=360743#file360743line298>
> >
> >     Nit: Would be better to use org.apache.flume.sink.hbase.IncrementAsyncHBaseSerializer.class.getName() so that this is refactorable and shadable.

Done.
> On Oct. 3, 2013, 6:34 a.m., Mike Percy wrote:
> > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java, line 310
> > <https://reviews.apache.org/r/14454/diff/1/?file=360743#file360743line310>
> >
> >     I'm confused why we are using the same Context object to configure both a Sink and a Channel. Probably a minor bug.

Seems like that is done through the entire test. I will fix it in the follow up jira mentioned above.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14454/#review26641
-----------------------------------------------------------
On Oct. 3, 2013, 5:32 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14454/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2013, 5:32 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2202
>     https://issues.apache.org/jira/browse/FLUME-2202
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Added a new config to coalesce increments.
>
>
> Diffs
> -----
>
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 5a59b56
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 5e297b1
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 7fdc75b
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/IncrementAsyncHBaseSerializer.java PRE-CREATION
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java a0c04eb
>
> Diff: https://reviews.apache.org/r/14454/diff/
>
>
> Testing
> -------
>
> All current tests pass. Added 2 new tests
>
>
> Thanks,
>
> Hari Shreedharan
>
>