Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1992 ElasticSearch dependency is marked optional


+
Edward Sargisson 2013-04-22, 21:03
+
Israel Ekpo 2013-04-22, 22:21
Copy link to this message
-
Re: Review Request: FLUME-1992 ElasticSearch dependency is marked optional
Edward Sargisson 2013-04-22, 22:34


> On April 22, 2013, 10:21 p.m., Israel Ekpo wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1763
> > <https://reviews.apache.org/r/10709/diff/1/?file=283223#file283223line1763>
> >
> >     I think you should a little bit more information to clarify which pom.xml they should examine.
> >    
> >     The client (ElasticSearchSink) has a pom file as well.
> >    
> >     So I think it would be better if we explicitly specify that the pom.xml to examine is that of the elasticsearch server cluster the sink is communicating with.

Thank you, Israel.
To my mind, I am happy with the wording as it stands as I do not see how a reader interpret the wording as looking in the pom.xml files in Flume itself.
- Edward
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10709/#review19551
-----------------------------------------------------------
On April 22, 2013, 9:03 p.m., Edward Sargisson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10709/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 9:03 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added info to user guide as users will need to select which JAR they use.
>
>
> Diffs
> -----
>
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
>
> Diff: https://reviews.apache.org/r/10709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Edward Sargisson
>
>

+
Israel Ekpo 2013-04-22, 22:54