Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 14856: HIVE-5552: Merging of QBJoinTrees doesn't handle filter pushdowns correctly


Copy link to this message
-
Re: Review Request 14856: HIVE-5552: Merging of QBJoinTrees doesn't handle filter pushdowns correctly


> On Oct. 24, 2013, 5:45 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 1403
> > <https://reviews.apache.org/r/14856/diff/1/?file=369330#file369330line1403>
> >
> >     Also, I think following may be needed:
> >     * HiveParser.KW_ARRAY
> >     * HiveParser.KW_STRUCT
> >     * HiveParser.KW_MAP

these are created as Function Nodes in the AST. So get handled as any Function, by the default case in checkJoinFilterRefersOneAlias
- Harish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14856/#review27465
-----------------------------------------------------------
On Oct. 24, 2013, 6:16 p.m., Harish Butani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14856/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 6:16 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-5552
>     https://issues.apache.org/jira/browse/HIVE-5552
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Merging of QBJoinTrees doesn't handle filter pushdowns correctly
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 12a0a69
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java 9834e73
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c886760
>   ql/src/test/queries/clientpositive/join_merging.q PRE-CREATION
>   ql/src/test/results/clientpositive/join_merging.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14856/diff/
>
>
> Testing
> -------
>
> ran all join tests.
> added join_merging.q test
>
>
> Thanks,
>
> Harish Butani
>
>