Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 13436: FLUME-2154 Reducing duplicate events caused by reset-connection-interval


Copy link to this message
-
Review Request 13436: FLUME-2154 Reducing duplicate events caused by reset-connection-interval
Juhani Connolly 2013-08-09, 03:02

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13436/
-----------------------------------------------------------

Review request for Flume.
Repository: flume-git
Description
-------

I removed the lock and set a flag in scheduled runnable. This flag is checked in process and a reconnect is performed if set.
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java b3208fc
  flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 8760c25

Diff: https://reviews.apache.org/r/13436/diff/
Testing
-------

Unit tests were adjusted(since a reconnect requires process to actually happen) and pass.

We tested with and without the patch on our servers and everything looks good with log duplication at the same level as having interval = 0
Thanks,

Juhani Connolly