Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> [jira] [Commented] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse


Copy link to this message
-
[jira] [Commented] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

    [ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627738#comment-13627738 ]

David Arthur commented on KAFKA-852:
------------------------------------

The responses should include correlation, but not client id. The client id is just used for logging purposes on the broker, but correlation is used for clients to do async request/response handling. From the protocol wiki page: "Response => CorrelationId ResponseMessage"

I had incorrectly included the client id in these two new responses (I originally was including version id as well, which was also a mistake - KAFKA-759).

https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-Responses
                
> Remove clientId from OffsetFetchResponse and OffsetCommitResponse
> -----------------------------------------------------------------
>
>                 Key: KAFKA-852
>                 URL: https://issues.apache.org/jira/browse/KAFKA-852
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1
>            Reporter: David Arthur
>            Assignee: David Arthur
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: 0001-KAFKA-852-remove-clientId-from-Offset-Fetch-Commit-R.patch, KAFKA-852.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> These are not needed and conflict with the API documentation. Should be removed to be consistent with other APIs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira