Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 15137: Patch for KAFKA-1107

Copy link to this message
Re: Review Request 15137: Patch for KAFKA-1107

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 31, 2013, 10:18 p.m.)
Review request for kafka and Jay Kreps.
Bugs: KAFKA-1107
Repository: kafka
Description (updated)

Per Jay's suggestion, avoid changing the public API of Log
Avoid printing clean shutdown file log message on every log
KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to 0.8.1; Fix includes modifying Log to avoid recovery if the clean shutdown file exists; LogManager deletes the clean shutdown file after all logs in a log directory have finished loading; If the clean shutdown file does not exist, fall back to 0.8.1 recovery logic
Diffs (updated)

  core/src/main/scala/kafka/log/Log.scala 0cc402b13e8484ae5569f1b8ff7156331a2f82d7
  core/src/main/scala/kafka/log/LogManager.scala d489e08452ab97334d504f76f381eb314ec56901
  core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala eeb8c8856200c5b2ed5fd8a7b9b28f813eabd67d
  core/src/test/scala/unit/kafka/log/CleanerTest.scala 5a312bf0803c1df4636e2e64ba83036a4e8e92dd
  core/src/test/scala/unit/kafka/log/LogTest.scala 140317c6ab6741308d125e9c1f43078b672c5f95

Diff: https://reviews.apache.org/r/15137/diff/

Neha Narkhede