Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 13908: Initial patch KAFKA-1012


Copy link to this message
-
Re: Review Request 13908: Initial patch KAFKA-1012

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13908/

(Updated Aug. 30, 2013, 9:19 p.m.)
Review request for kafka, Jay Kreps and Neha Narkhede.
Repository: kafka
Description

See https://issues.apache.org/jira/browse/KAFKA-1012 for details.
Diffs

  config/server.properties 7685879c2ab3d2dde1561bd34e6d9c55bc2429e3
  core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
  core/src/main/scala/kafka/common/ErrorMapping.scala 153bc0b078d21200c02c47dd5ad9b7a7e3326ec4
  core/src/main/scala/kafka/common/OffsetMetadataAndError.scala 59608a34202b4a635582c74c0068f3ae1bde0a13
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala e3a64204513467cef8917f501c3bc0e5b1db2e3e
  core/src/main/scala/kafka/producer/DefaultPartitioner.scala 37ddd55b49680262ac348f77bb029dd4e84958cb
  core/src/main/scala/kafka/server/KafkaApis.scala 0ec031ad9423b82ba9c8a49fe984337620392a8b
  core/src/main/scala/kafka/server/KafkaConfig.scala ebbbdea8ab8798c95b39be9594b5b805a0f29d29
  core/src/main/scala/kafka/server/KafkaServer.scala a925ae1a41fcb71f00ddf9e111172ec8a7fca749
  core/src/main/scala/kafka/server/OffsetManager.scala PRE-CREATION
  core/src/main/scala/kafka/server/ReplicaManager.scala 73c87c663981002b52a0c4995a6ef96ca24d5ef4
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala bc415e3156810db6c41509d9eb4aed4484496eee
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala c0475d07a778ff957ad266c08a7a81ea500debd2
  core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala bab436dcef1645b5e327a5e7e68abdbe57604745

Diff: https://reviews.apache.org/r/13908/diff/
Testing

Manual testing with 3 brokers, 2 producers and 6 consumers. Existing junits pass
Thanks,

Tejas Patil