Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> git workflow


Copy link to this message
-
Re: git workflow
You can amend the previous commit (as long as you havent pushed) with an
author like "git --amend --author='...'"

On Saturday, January 5, 2013, Joe Stein wrote:

> I am getting the no email after doing
>
> git am --signoff < xyz.patch
>
> so nothing gets in to commit to set the author :(
>
> On Sat, Jan 5, 2013 at 12:30 AM, Jay Kreps <[EMAIL PROTECTED]<javascript:;>>
> wrote:
>
> > I have but I don't really know why. This format worked for me:
> >   git commit --author='Bertrand Russell <[EMAIL PROTECTED]<javascript:;>
> >'
> >
> >
> > On Fri, Jan 4, 2013 at 8:35 PM, Joe Stein <[EMAIL PROTECTED]<javascript:;>>
> wrote:
> >
> > > I started following this so far really helpful thanks!!
> > >
> > > Running into some issues reviewing someone's patch getting "Patch does
> > not
> > > have a valid e-mail address." googling to figure out what is wrong
> > figure I
> > > mention here if anyone bumped into this yet
> > >
> > > thnx
> > >
> > > On Thu, Jan 3, 2013 at 11:17 AM, Jun Rao <[EMAIL PROTECTED]<javascript:;>>
> wrote:
> > >
> > > > Thanks for documenting this. Could you also add how to resolve
> > conflicts
> > > > during rebase?
> > > >
> > > > Jun
> > > >
> > > > On Wed, Jan 2, 2013 at 1:45 PM, Jay Kreps <[EMAIL PROTECTED]<javascript:;>>
> wrote:
> > > >
> > > > > I don't know about other people but I find git kind of confusing. I
> > > > thought
> > > > > it would be useful to try to document the normal workflow for
> > different
> > > > use
> > > > > cases:
> > > > > 1. Contributing a patch
> > > > > 2. Reviewing and integrating a patch that is contributed
> > > > > 3. Doing development as a committer
> > > > > 4. Keeping a copy of your local work on github (since it doesn't
> seem
> > > > > Apache has a place to keep local backups of work in progress).
> > > > >
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/Git+Workflow
> > > > >
> > > > > I would like to link this up from the contributor page to help
> people
> > > > > (including my future self). Objections?
> > > > >
> > > > > I am not a git expert, so any feedback to improve these recipes or
> > bug
> > > > > fixes (since I haven't tried everything) would be very much
> > > appreciated.
> > > > If
> > > > > you are about to do one of the above things, try the recipe and see
> > if
> > > it
> > > > > can be improved.
> > > > >
> > > > > Cheers,
> > > > >
> > > > > -Jay
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > /*
> > > Joe Stein
> > > http://www.linkedin.com/in/charmalloc
> > > Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> > > */
> > >
> >
>
>
>
> --
>
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */
>
--
David Arthur