Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 16360: Address comments from Neha, and record error messages if leader brokers are not available since this should not happen then


Copy link to this message
-
Re: Review Request 16360: Address comments from Neha, and record error messages if leader brokers are not available since this should not happen then

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16360/#review32147
-----------------------------------------------------------

core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
<https://reviews.apache.org/r/16360/#comment60853>

    Need to change this comment accordingly.

core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/16360/#comment60852>

    present => be present
    now => not
- Jun Rao
On Jan. 16, 2014, 11:02 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16360/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 11:02 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1188
>     https://issues.apache.org/jira/browse/KAFKA-1188
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1188.v6
>
>
> KAFKA-1188.v5.1
>
>
> KAFKA-1188.v5
>
>
> Dummy
>
>
> KAFKA-1188.v4
>
>
> KAFKA-1188.v3
>
>
> KAFKA-1118.v2
>
>
> KAFKA-1188.v1
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/cluster/Partition.scala 1087a2e91c86e36a2494a95913a3ec2daf238287
>   core/src/main/scala/kafka/controller/ReplicaStateMachine.scala 483559aa64726c51320d18b64a1b48f8fb2905a0
>   core/src/main/scala/kafka/server/ReplicaManager.scala f9d10d385cee49a1e3be8c82e3ffa22ef87a8fd6
>
> Diff: https://reviews.apache.org/r/16360/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>