Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 20050: Fix KAFKA-1359


Copy link to this message
-
Re: Review Request 20050: Fix KAFKA-1359
Guozhang Wang 2014-04-04, 21:35

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20050/#review39598

clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/20050/#comment72038>

    Ideal we should be using Utils.notNull for all these. But we can't since some unit/integration tests bypass the metric registration phase and causing NPE. I tried to create a MockMetrics and MockSensor but that does not work perfectly either. If people have better suggestion I would love to make a change.
- Guozhang Wang
On April 4, 2014, 9:33 p.m., Guozhang Wang wrote: