I've converted the state.change.logger to use the Logging trait. That takes care of all the if statements. So I think we are covered here - Neha Narkhede On March 30, 2014, 6:29 a.m., Neha Narkhede wrote:
Not sure if I'm missing something, but isn't the string format is going to be called here no matter what? I don't think this is a lambda function right? - Timothy Chen On March 30, 2014, 6:29 a.m., Neha Narkhede wrote:
I see what you are saying now. Yes, I think you are right. This patch only addresses the conversion to the standard logging trait but the string formatting will still happen.
I think this JIRA is filed to fix the actual logging due to the absence of the check. I've filed KAFKA-1351 to fix all the String.format uses properly, which is a general problem much beyond just the state change logger. - Neha Narkhede On March 30, 2014, 6:29 a.m., Neha Narkhede wrote:
Yes you are correct, this shouldn't be a issue if we use our logging trait. - Timothy This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39022 On March 30, 2014, 6:29 a.m., Neha Narkhede wrote:
All projects made searchable here are trademarks of the Apache Software Foundation.
Service operated by Sematext