-
[jira] [Updated] (KAFKA-745) Remove getShutdownReceive() and other kafka specific code from the RequestChannel"Sriram Subramanian 2013-02-06, 11:12
[ https://issues.apache.org/jira/browse/KAFKA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sriram Subramanian updated KAFKA-745:
-------------------------------------
Attachment: KAFKA-745-v1.patch
This is a first version.
1. Removes all the metric stuff,requestObj etc from Request.
2.Adds Network metrics to track network level parameters
3. Any form of delayed request now uses a trimmed version of the Request object.
4. Added Request metrics to the kafka layer to track kafka specific parameters
TODO - Need to add logging.
- Some more cleanup
- We will not get all the different times for a given request as part of one log statement anymore. I think this is fine for the ability to maintain clean code.
- W.r.t the logging in the network layer, we would get info from the Request object (need to add a toString here to ignore the buffer) and nothing from the actual request. I think this is fine since knowing the request type is not useful at this layer based on the explanation above.
> Remove getShutdownReceive() and other kafka specific code from the RequestChannel
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-745
> URL: https://issues.apache.org/jira/browse/KAFKA-745
> Project: Kafka
> Issue Type: Bug
> Components: network
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Sriram Subramanian
> Priority: Critical
> Attachments: KAFKA-745-v1.patch
>
>
> Jay's suggestion from KAFKA-736 is to get rid of getShutdownReceive() and kafka request specific code from the generic requestchannel
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
+
"Sriram Subramanian 2013-02-22, 20:24
