Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Re: Review Request 19388: Patch for KAFKA-1251


Copy link to this message
-
Re: Review Request 19388: Patch for KAFKA-1251
Jun Rao 2014-03-25, 01:38

5. Got it. It wasn't obvious to me that KafkaMetrics.lock is actually the sensor lock. Perhaps we could rename it to sensorLock?

7. Yes, that's another issue. My original question is a bit different. Say we keep one sample with a window size of 30 secs. At time 20 sec an event is recorded. We will use 1/(now - 20) to calculate the rate. However, there wasn't any update from 0 to 20. So, may be the rate should be 1/(now - 0)?

I think at least for request rate, it's probably useful to see the producer request and metadata request separately at the client?
- Jun
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19388/#review38261
On March 20, 2014, 12:30 a.m., Jay Kreps wrote: