Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 24653: Patch for KAFKA-1577


Copy link to this message
-
Re: Review Request 24653: Patch for KAFKA-1577

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24653/#review50495
I saw a bunch of whitespaces diffs. Do you know why those were introduced in the patch?
core/src/main/scala/kafka/network/SocketServer.scala
<https://reviews.apache.org/r/24653/#comment88321>

    While this may fix the NoSuchElementException, I wonder why the error happened in the first place as it may point to a bug in the way we are using the connection quotas. For example, are we trying to shut down the same socket channel twice somehow?
    
    Finding this will also help write a unit test for this, if possible.
- Neha Narkhede
On Aug. 13, 2014, 4:11 p.m., Sriharsha Chintalapani wrote: