Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Patch for mmap + windows


Copy link to this message
-
Re: Patch for mmap + windows
Jay Kreps 2013-09-10, 01:23
I think Srirams complaint is that I haven't yet addressed his concerns :-)

Sent from my iPhone

On Sep 9, 2013, at 3:56 PM, Sriram Subramanian <[EMAIL PROTECTED]> wrote:

> I did take a look at KAFKA-1008 a while back and added some comments.
>
> On 9/9/13 3:52 PM, "Jay Kreps" <[EMAIL PROTECTED]> wrote:
>
>> Cool can we get a reviewer for KAFKA-1008 then? I can take on the other
>> issue for the checkpoint files.
>>
>> -Jay
>>
>>
>> On Mon, Sep 9, 2013 at 3:16 PM, Neha Narkhede
>> <[EMAIL PROTECTED]>wrote:
>>
>>> +1 for windows support on 0.8
>>>
>>> Thanks,
>>> Neha
>>>
>>>
>>> On Mon, Sep 9, 2013 at 10:48 AM, Jay Kreps <[EMAIL PROTECTED]> wrote:
>>>
>>>> So guys, do we want to do these in 0.8? The first patch was a little
>>>> involved but I think it would be good to have windows support in 0.8
>>> and
>>> it
>>>> sounds like Tim is able to get things working after these changes.
>>>>
>>>> -Jay
>>>>
>>>>
>>>> On Mon, Sep 9, 2013 at 10:19 AM, Timothy Chen <[EMAIL PROTECTED]>
>>> wrote:
>>>>
>>>>> Btw, I've been running this patch in our cloud env and it's been
>>> working
>>>>> fine so far.
>>>>>
>>>>> I actually filed another bug as I saw another problem on windows
>>> locally
>>>> (
>>>>> https://issues.apache.org/jira/browse/KAFKA-1036).
>>>>>
>>>>> Tim
>>>>>
>>>>>
>>>>> On Wed, Aug 21, 2013 at 4:29 PM, Jay Kreps <[EMAIL PROTECTED]>
>>> wrote:
>>>>>
>>>>>> That would be great!
>>>>>>
>>>>>> -Jay
>>>>>>
>>>>>>
>>>>>> On Wed, Aug 21, 2013 at 3:13 PM, Timothy Chen <[EMAIL PROTECTED]>
>>>> wrote:
>>>>>>
>>>>>>> Hi Jay,
>>>>>>>
>>>>>>> I'm planning to test run Kafka on Windows in our test
>>> environments
>>>>>>> evaluating if it's suitable for production usage.
>>>>>>>
>>>>>>> I can provide feedback with the patch how well it works and if
>>> we
>>>>>> encounter
>>>>>>> any functional or perf problems.
>>>>>>>
>>>>>>> Tim
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Aug 21, 2013 at 2:54 PM, Jay Kreps <[EMAIL PROTECTED]>
>>>>> wrote:
>>>>>>>
>>>>>>>> Elizabeth and I have a patch to support our memory mapped
>>> offset
>>>>> index
>>>>>>>> files properly on Windows:
>>>>>>>> https://issues.apache.org/jira/browse/KAFKA-1008
>>>>>>>>
>>>>>>>> Question: Do we want this on 0.8 or trunk? I would feel more
>>>>>> comfortable
>>>>>>>> with it in trunk, but that means windows support in 0.8 is
>>> known
>>> to
>>>>> be
>>>>>>>> broken (as opposed to "not known to be broken but not known
>>> to be
>>>>>> working
>>>>>>>> either" since we are not doing aggressive system testing on
>>>> windows).
>>>>>>>>
>>>>>>>> I would feel more comfortable doing the patch on 0.8 if there
>>> was
>>>>>> someone
>>>>>>>> who would be willing to take on real load testing and/or
>>> production
>>>>>>>> operation on Windows so we could have some confidence that
>>> Kafka
>>> on
>>>>>>> Windows
>>>>>>>> actually works, otherwise this could just be the tip of the
>>>> iceberg.
>>>>>>>>
>>>>>>>> Also it would be great to get review on that patch regardless
>>> of
>>>> the
>>>>>>>> destination.
>>>>>>>>
>>>>>>>> -Jay
>