Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 24676: WIP for KAFKA-1583


Copy link to this message
-
Re: Review Request 24676: WIP for KAFKA-1583

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24676/#review50887

core/src/main/scala/kafka/server/RequestPurgatory.scala
<https://reviews.apache.org/r/24676/#comment88762>

    Is watched still being used?

core/src/main/scala/kafka/server/RequestPurgatory.scala
<https://reviews.apache.org/r/24676/#comment88761>

    Could this be called completed()?

core/src/main/scala/kafka/server/RequestPurgatory.scala
<https://reviews.apache.org/r/24676/#comment88759>

    We removed the synchronization on t. Do we expect t.tryComplete to be thread safe?
- Jun Rao
On Aug. 13, 2014, 11:16 p.m., Guozhang Wang wrote: