Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 17671: Fix KAFKA-1235


Copy link to this message
-
Re: Review Request 17671: Fix KAFKA-1235

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17671/#review35013
The patch doesn't apply to chunk. Could you rebase?
core/src/main/scala/kafka/consumer/SimpleConsumer.scala
<https://reviews.apache.org/r/17671/#comment65386>

    Would it better to always call blockingChannel.disconnect() since it's already doing the same check there?

core/src/main/scala/kafka/producer/SyncProducer.scala
<https://reviews.apache.org/r/17671/#comment65387>

    Would it better to always call blockingChannel.disconnect() since it's already doing the same check there?

core/src/main/scala/kafka/server/KafkaServer.scala
<https://reviews.apache.org/r/17671/#comment65388>

    Wouldn't just setting maxRetries to maxInt achieve the same thing?

core/src/main/scala/kafka/server/KafkaServer.scala
<https://reviews.apache.org/r/17671/#comment65389>

    Actual, not sure why we need this. Closing zkclient will automatically deregister the ephemeral node.
- Jun Rao
On Feb. 19, 2014, 11:57 p.m., Guozhang Wang wrote: