Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> Review Request 18102: Integration Test for New Producer: Part II


+
Guozhang Wang 2014-02-13, 23:10
+
Guozhang Wang 2014-02-13, 23:13
+
Guozhang Wang 2014-02-13, 23:15
+
Guozhang Wang 2014-02-13, 23:17
+
Jay Kreps 2014-02-14, 19:22
Copy link to this message
-
Re: Review Request 18102: Integration Test for New Producer: Part II

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18102/#review35559

Ship it!
+1 Just the following minor comments.
core/src/main/scala/kafka/server/KafkaApis.scala
<https://reviews.apache.org/r/18102/#comment66164>

    Could we change this to the following? Then we can use the name instead _1.
    
    for ( (topicPartition, responseStatus) <- ...

core/src/test/scala/integration/kafka/api/ProducerSendTest.scala
<https://reviews.apache.org/r/18102/#comment66162>

    Shouldn't we add the code to call send after producer.close()?
- Jun Rao
On Feb. 26, 2014, 5:48 p.m., Guozhang Wang wrote:
 
+
Jun Rao 2014-02-26, 02:47
+
Jay Kreps 2014-02-27, 03:50