Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 23593: Fix KAFKA-1533: Address Jun's comments


Copy link to this message
-
Review Request 23593: Fix KAFKA-1533: Address Jun's comments

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23593/

Review request for kafka.
Bugs: KAFKA-1533
    https://issues.apache.org/jira/browse/KAFKA-1533
Repository: kafka
Description

1. Add the metadataRefreshAttemptMS in NetworkClient for backing off; 2. Refactor Producer API tests using KafkaTestHarness; 3. Change default backoff time to 100ms for test utils
Diffs

  clients/src/main/java/org/apache/kafka/clients/NetworkClient.java d8f9ce663ee24d2b0852c974136741280c39f8f8
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 4aa5b01d611631db72df47d50bbe30edb8c478db
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 15fd5bcbaf175a0f7d7cf0b142e63f705ca9b6ae
  core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 34a7db4b4ea2b720476c2b1f22a623a997faffbc
  core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala 194dd70919a5f301d3131c56594e40a0ebb27311
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 3faa884f8eb83c7c00baab416d0acfb488dc39c1

Diff: https://reviews.apache.org/r/23593/diff/
Testing
Thanks,

Guozhang Wang