Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - review board is available


Copy link to this message
-
Re: review board is available
Jay Kreps 2013-09-10, 04:18
Yeah the lack of integration is kind of maddening if you have ever used
github.

My recommendation is that we treat Review Board as just a patch viewer and
discussion tool. In other words you must have a JIRA and a link to the
appropriate review board there. We should make no effort to use review
board's dashboard or close the rbs or anything like that. I think it is
reasonable to give the +1 in RB, though.

Not sure how other projects do it.

One simple thing that would help would be to get a wrapper script for
post-review and the jira command-line tool (
https://bobswift.atlassian.net/wiki/display/JCLI/JIRA+Command+Line+Interface).
I want something that takes a JIRA such as KAFKA-123 and generates a patch
and uploads it to both JIRA and rb, updating an existing rb if one is
specified.

-Jay
On Mon, Sep 9, 2013 at 2:32 PM, Guozhang Wang <[EMAIL PROTECTED]> wrote:

> Same concern. It seems that ReviewBoard would not, say, mark the JIRA as
> patch available when request is published. Does that mean we have to keep
> doing this manually still?
>
> Guozhang
>
>
> On Sun, Sep 8, 2013 at 10:04 AM, Neha Narkhede <[EMAIL PROTECTED]
> >wrote:
>
> > This is great. So far I reviewed 2 patches using reviewboard and it is a
> > huge time saver. I have one question about the setup though - the
> > reviewboard has a Bugs field that takes in the JIRA, can it update the
> > respective JIRA with the reviewboard link ?  The concern is that with
> more
> > reviews coming in through review board, it will soon become intractable
> > since there is also no easy way to search by Bug in reviewboard.
> >
> > Thanks,
> > Neha
> >
> >
> >
> > On Mon, Aug 26, 2013 at 1:00 PM, Jay Kreps <[EMAIL PROTECTED]> wrote:
> >
> > > Okay I got review board set up. I'm not wedded to this tool, but it's
> > > pretty simple so let's give it a try and if it sucks we can switch to
> > > phabricator or something else.
> > >
> > > I wrote up instructions on how to use it here:
> > > https://cwiki.apache.org/confluence/display/KAFKA/Review+Board
> > >
> > > If anyone has better info on workflow it would be great to help people
> > > figure it out. Ideally if we end up liking this tool it would be good
> to
> > > integrate it into the git workflow tool and ideally have some script to
> > > handle both the JIRA attachment and the review board.
> > >
> > > -Jay
> > >
> >
>
>
>
> --
> -- Guozhang
>