Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 24214: Patch for KAFKA-1374


Copy link to this message
-
Re: Review Request 24214: Patch for KAFKA-1374

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review49611
Thanks for the patch. Some comments below.
core/src/main/scala/kafka/log/LogCleaner.scala
<https://reviews.apache.org/r/24214/#comment86836>

    We probably should just record the compressed size in stats.recopyMessage() since that's the size actually got copied over.

core/src/main/scala/kafka/log/LogCleaner.scala
<https://reviews.apache.org/r/24214/#comment86842>

    Could we use Compressor.putRecord? Then,we don't have to worry about the details of the message format.

core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
<https://reviews.apache.org/r/24214/#comment86841>

    Would it be better to make this a parameterized test so that we can test all compression codec?
- Jun Rao
On Aug. 3, 2014, 5:40 p.m., Manikumar Reddy O wrote: