Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 16175: Patch for KAFKA-1178


Copy link to this message
-
Re: Review Request 16175: Patch for KAFKA-1178

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16175/
-----------------------------------------------------------

(Updated Dec. 11, 2013, 6:30 p.m.)
Review request for kafka.
Bugs: KAFKA-1178
    https://issues.apache.org/jira/browse/KAFKA-1178
Repository: kafka
Description (updated)
-------

Addressed review comments regarding comments, improved unit tests to check for under replicated partition count post reassignment
1. Fixed broker to only follow become-follower/leader request if the broker exists in the assigned replica list 2. Changed the under replicated check to compare in sync replica set size with assigned replica set size instead of passed in replication factor 3. Fixed the fetcher id computation to not create more fetcher threads than necessary due to the negative (overflown) hashcode value. 4. Fixed some more state change logging 5. Tested partition reassignment several times on a cluster with several 100s of topics, verified reassignment completion followed by no under replicated partitions (through jmx and through zookeeper)
Diffs (updated)
-----

  core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 65c04edc11a1eb2771bfd741d59886b5fef9ccbc
  core/src/main/scala/kafka/cluster/Partition.scala 13f48baa1bc44533c33153fde6f1c03a067d83bc
  core/src/main/scala/kafka/controller/KafkaController.scala fd92c65f1d067d1bf7096df41beb652edaceec87
  core/src/main/scala/kafka/server/AbstractFetcherManager.scala 394e981c858fa53a28d3c7fcef0afbd4faf07858
  core/src/main/scala/kafka/server/ReplicaManager.scala b0a39622ab91e209f9657231917a5ae30fd835f0
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 86f88f5f06ecc2cb1c8d5436db93b36ccea9e938

Diff: https://reviews.apache.org/r/16175/diff/
Testing
-------
Thanks,

Neha Narkhede