Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - [jira] [Commented] (KAFKA-875) System test cleanup


Copy link to this message
-
[jira] [Commented] (KAFKA-875) System test cleanup
"Swapnil Ghike 2013-04-24, 05:59

    [ https://issues.apache.org/jira/browse/KAFKA-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640134#comment-13640134 ]

Swapnil Ghike commented on KAFKA-875:
-------------------------------------

And we should also do something about this trippy diff that pops up every time one tries to run a system test :)

diff --git a/system_test/testcase_to_run.json b/system_test/testcase_to_run.json
index 8252860..c6cf17e 100644
--- a/system_test/testcase_to_run.json
+++ b/system_test/testcase_to_run.json
@@ -1,5 +1,5 @@
 {
     "ReplicaBasicTest"   : [
-        "testcase_0001"
+        "testcase_1"
     ]
 }
                
> System test cleanup
> -------------------
>
>                 Key: KAFKA-875
>                 URL: https://issues.apache.org/jira/browse/KAFKA-875
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: John Fung
>              Labels: cleanup
>
> There is a lot of unused stuff lying in system_test. If we have converted all the bash tests to python, we should delete the unused code.
> Also there is commented code at a few places that should be deleted if it is not going to be used. For instance, search for brokerLogCksumDict in system_test/utils/kafka_system_test_utils.py.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira