Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 23339: Patch for KAFKA-1507


Copy link to this message
-
Review Request 23339: Patch for KAFKA-1507

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23339/

Review request for kafka.
Bugs: KAFKA-1507
    https://issues.apache.org/jira/browse/KAFKA-1507
Repository: kafka
Description

KAFKA-1507. Using GetOffsetShell against non-existent topic creates the topic unintentionally.
Diffs

  core/src/main/scala/kafka/api/TopicMetadataRequest.scala a319f2f438bfd84c63edb330685b2b41d4b08aa0
  core/src/main/scala/kafka/client/ClientUtils.scala ce7ede3f6d60e756e252257bd8c6fedc21f21e1c
  core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala 7e6da164a26b1893c26c624a9998d4fedf8af95e
  core/src/main/scala/kafka/producer/BrokerPartitionInfo.scala 13a8aa665016e19284c8ced35bac2195fe9e4378
  core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 9c6064e201eebbcd5b276a0dedd02937439edc94
  core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 36314f412a8281aece2789fd2b74a106b82c57d2
  core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 35dc071b1056e775326981573c9618d8046e601d

Diff: https://reviews.apache.org/r/23339/diff/
Testing
Thanks,

Sriharsha Chintalapani