Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 14865: Patch for KAFKA-1097


Copy link to this message
-
Re: Review Request 14865: Patch for KAFKA-1097


It doesn't. See this

    // change the assigned replica list to just the reassigned replicas in the cache so it gets sent out on the LeaderAndIsr
    // request to the current or new leader. This will prevent it from adding the old replicas to the ISR
    val oldAndNewReplicas = controllerContext.partitionReplicaAssignment(topicAndPartition)
    controllerContext.partitionReplicaAssignment.put(topicAndPartition, reassignedReplicas)

We do this before the partitionStateMachine.handleStateChanges() call and it correctly sends the shrunk assigned replicas.

Though both are same, changed it

Agree, but I'm afraid I may be missing some corner cases in which case sending more data will be useful compared to sending less data.
- Neha
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14865/#review28011
On Oct. 31, 2013, 5:37 p.m., Neha Narkhede wrote: