Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 18343: Patch for KAFKA-1250


Copy link to this message
-
Re: Review Request 18343: Patch for KAFKA-1250

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18343/#review35532
1. Is there a reason that you want to change the license header? We should stay with one format of the license header.

clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
<https://reviews.apache.org/r/18343/#comment66121>

    I am still confused here. Could you clarify when we should add a matching {} for exception? The usage in line 89 and line 77 is not consistent. My understanding is that if exception is the only parameter, you don't need to add the {}. Otherwise, you will. Is that correct?

clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/18343/#comment66122>

    Are we missing a {}?

clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
<https://reviews.apache.org/r/18343/#comment66123>

    From the mailing list discussion, most people prefer to see this in info (at least the overridden values) level.
- Jun Rao
On Feb. 26, 2014, 5:32 a.m., Jay Kreps wrote: