Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> [jira] [Comment Edited] (KAFKA-648) Use uniform convention for naming properties keys


Copy link to this message
-
[jira] [Comment Edited] (KAFKA-648) Use uniform convention for naming properties keys

    [ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547063#comment-13547063 ]

John Fung edited comment on KAFKA-648 at 1/8/13 7:01 PM:
---------------------------------------------------------

The testcase_xxxx_properties.json files in System Test will need to be updated for the following changes:

brokerid => broker.id
hostname => host.name
log.file.size => log.segment.size
groupid => group.id

A separate JIRA KAFKA-688 is created for this task.
                
      was (Author: jfung):
    The testcase_xxxx_properties.json files in System Test will need to be updated for the following changes:

brokerid => broker.id
hostname => host.name
log.file.size => log.segment.size

A separate JIRA KAFKA-688 is created for this task.
                  
> Use uniform convention for naming properties keys
> --------------------------------------------------
>
>                 Key: KAFKA-648
>                 URL: https://issues.apache.org/jira/browse/KAFKA-648
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8, 0.8.1
>
>         Attachments: configchanges-1.patch, configchanges-v2.patch
>
>
> Currently, the convention that we seem to use to get a property value in *Config is as follows:
> val configVal = property.getType("config.val", ...) // dot is used to separate two words in the key and the first letter of second word is capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId, correlationId.
> This change will probably be backward non-compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira