Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> Review Request 21878: KAFKA-1468: Misc. improvements to test scripts from benchmarking


+
Jay Kreps 2014-05-23, 21:08
Copy link to this message
-
Re: Review Request 21878: KAFKA-1468: Misc. improvements to test scripts from benchmarking

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21878/#review44087

clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java
<https://reviews.apache.org/r/21878/#comment78418>

    Is target_throughput in bytes/sec?

clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java
<https://reviews.apache.org/r/21878/#comment78419>

    Not sure that I follow how the sleeping logic works. Could you add some comments?

clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java
<https://reviews.apache.org/r/21878/#comment78416>

    Should we call this OnCompletionCallback? OnCompeletion.onCompletion() is a bit confusing.

clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java
<https://reviews.apache.org/r/21878/#comment78417>

    Should we handle the error case here?
- Jun Rao
On May 23, 2014, 9:08 p.m., Jay Kreps wrote:
 
+
Jay Kreps 2014-05-28, 23:15