Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 16360: Patch for KAFKA-1188


Copy link to this message
-
Re: Review Request 16360: Patch for KAFKA-1188
Guozhang Wang 2013-12-20, 23:22

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16360/#review30768
-----------------------------------------------------------

core/src/main/scala/kafka/cluster/Partition.scala
<https://reviews.apache.org/r/16360/#comment58913>

    Originally the leader broker needs to be searched twice, once in ReplicaManager and once in Partition for checking if the leader is available, and the bug comes from the check in Partition does not stop the transition. So here I wanted to merge them into one check in Partition and also save the searching in ReplicaManager. I agree that the return type is not very neat here. Will change to having the check on ReplicaManager.

core/src/main/scala/kafka/cluster/Partition.scala
<https://reviews.apache.org/r/16360/#comment58914>

    Reason same as above. Will fix accordingly

core/src/main/scala/kafka/cluster/Partition.scala
<https://reviews.apache.org/r/16360/#comment58915>

    Done.

core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/16360/#comment58916>

    Thanks. Done.

core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/16360/#comment58917>

    This logging for all the partitions.
- Guozhang Wang
On Dec. 19, 2013, 3:01 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16360/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 3:01 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1188
>     https://issues.apache.org/jira/browse/KAFKA-1188
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1188.v1
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/cluster/Partition.scala 5c9307d71641ccc6c09a54b69d5aa2b4bc2a4cde
>   core/src/main/scala/kafka/server/ReplicaManager.scala 242c18d47828b7c5e6b1fc219a0f1199fb1f9512
>
> Diff: https://reviews.apache.org/r/16360/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>