Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> Review Request 14638: Patch for KAFKA-1086


+
Neha Narkhede 2013-10-14, 22:50
+
Jun Rao 2013-10-15, 16:33
+
Neha Narkhede 2013-10-16, 02:50
+
Joel Koshy 2013-10-15, 20:03
+
Joel Koshy 2013-10-15, 20:07
+
Neha Narkhede 2013-10-16, 23:30
Copy link to this message
-
Re: Review Request 14638: Patch for KAFKA-1086

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14638/
-----------------------------------------------------------

(Updated Oct. 16, 2013, 11:29 p.m.)
Review request for kafka.
Bugs: KAFKA-1086
    https://issues.apache.org/jira/browse/KAFKA-1086
Repository: kafka
Description (updated)
-------

Incorporated Joel's review comments
Minor change to patch review tool
Changed command line parameter partition->partitions
Improved GetOffsetShell to query metadata automatically, add batch offset request for all partitions of a topic and improve usability
Diffs (updated)
-----

  core/src/main/scala/kafka/tools/GetOffsetShell.scala 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d
  kafka-patch-review.py f1d5192057755e9cd24861c1f995638e2eada1d1

Diff: https://reviews.apache.org/r/14638/diff/
Testing
-------
Thanks,

Neha Narkhede