Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 15964: Patch for KAFKA-1156


Copy link to this message
-
Re: Review Request 15964: Patch for KAFKA-1156
Neha Narkhede 2013-12-03, 23:23


> On Dec. 3, 2013, 10:46 p.m., Jun Rao wrote:
> > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, lines 181-182
> > <https://reviews.apache.org/r/15964/diff/2/?file=393096#file393096line181>
> >
> >     Could we put the sentence starting from Save in a new line? Also, may be we can remove the dot at the end of the first sentence since it's not part of the json output.

Good observation, Jun :)
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15964/#review29688
-----------------------------------------------------------
On Dec. 3, 2013, 6:21 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15964/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:21 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1156
>     https://issues.apache.org/jira/browse/KAFKA-1156
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Found and fixed a bug during partition reassignment if a partition is being reassigned to the same set of replicas repeatedly
>
>
> Improved the partition reassignment tool to - 1) Output the previous partition replica assignment before kicking off the new assignment, to help with rollback 2) Have 3 options - generate, verify, execute 3) Cleaned up tool to use the 3 options properly
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 70d1b81f7dab2b3316af77738d682427d668be14
>   core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15964/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>