Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka, mail # dev - [jira] [Commented] (KAFKA-1081) kafka-run-class.sh is broken


+
Francois Saint-Jacques 2013-10-10, 18:37
+
Francois Saint-Jacques 2013-10-10, 19:33
+
Anatoly Fayngelerin 2013-10-11, 20:18
+
Joe Stein 2013-10-12, 03:52
Copy link to this message
-
[jira] [Commented] (KAFKA-1081) kafka-run-class.sh is broken
"Jun Rao 2013-10-13, 21:29

    [ https://issues.apache.org/jira/browse/KAFKA-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793789#comment-13793789 ]

Jun Rao commented on KAFKA-1081:
--------------------------------

Thanks for the patch. +1. Could you patch for trunk as well?

> kafka-run-class.sh is broken
> ----------------------------
>
>                 Key: KAFKA-1081
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1081
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Francois Saint-Jacques
>         Attachments: KAFKA-1081-v1.patch
>
>
> Please apply this patch, this is why log4j exists. Rerunning at non-deterministic command twice to catch error message is extremely dangerous.
> diff --git a/bin/kafka-run-class.sh b/bin/kafka-run-class.sh
> index eb6ff1b..2f2d8b5 100755
> --- a/bin/kafka-run-class.sh
> +++ b/bin/kafka-run-class.sh
> @@ -102,19 +102,3 @@ if [ "$1" = "daemon" ] && [ -z "$KAFKA_GC_LOG_OPTS"] ; then
>  fi
>  $JAVA $KAFKA_HEAP_OPTS $KAFKA_JVM_PERFORMANCE_OPTS $KAFKA_GC_LOG_OPTS $KAFKA_JMX_OPTS $KAFKA_LOG4J_OPTS -cp $CLASSPATH $KAFKA_OPTS "$@"
> -
> -exitval=$?
> -
> -if [ $exitval -eq "1" ] ; then
> -       $JAVA $KAFKA_HEAP_OPTS $KAFKA_JVM_PERFORMANCE_OPTS $KAFKA_GC_LOG_OPTS $KAFKA_JMX_OPTS $KAFKA_LOG4J_OPTS -cp $CLASSPATH $KAFKA_OPTS "$@" >& exception.txt
> -       exception=`cat exception.txt`
> -       noBuildMessage='Please build the project using sbt. Documentation is available at http://kafka.apache.org/'
> -       pattern="(Could not find or load main class)|(java\.lang\.NoClassDefFoundError)"
> -       match=`echo $exception | grep -E "$pattern"`
> -       if [[ -n "$match" ]]; then
> -               echo $noBuildMessage
> -       fi
> -       rm exception.txt
> -fi
> -
> -

--
This message was sent by Atlassian JIRA
(v6.1#6144)