Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.


Copy link to this message
-
Re: Review Request 18343: KAFKA-1250: Add logging to new Kafka producer.
Jay Kreps 2014-02-26, 04:51

We have two things: the full config values and the user-suplied strings (later are a subset of the former). I think the full config values are more useful as they include any parsing logic as well as showing the default so I'll do those.

My approach was I wrote the logging and used it to debug some issues. My criteria was the following:
1. Normal non-failure should have no logging by default since we are just a humble client
2. Debug should produce stuff that is of general noteworthiness when you turn on logging. My criteria was roughly that running in debug you should hear about all noteworthy things that occur but have gobs of logging. You should be okay running with debug logging on with little or no per impact.
3. Trace is more detailed step-by-step tracing of all execution including fairly boring stuff like messages passing through different layers.

So I guess the questions are (1) do those criteria make sense, and (2) is this something you would probably want to know about in debug level.

Done.

This is definitely in my definition of trace above (i.e. almost certainly not interesting and totally normal steady-state behavior.

Done.
- Jay
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18343/#review35431
On Feb. 21, 2014, 4:26 a.m., Jay Kreps wrote: