Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x


Copy link to this message
-
Re: Review Request 14013: Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14013/#review25977
Overall, this is a great patch. Thanks for contributing it. I have some minor questions/suggestions.
core/build.sbt
<https://reviews.apache.org/r/14013/#comment50698>

    Does Scala 2.10 require scalatest 1.9.1?
    How about Scala 2.9.x ?

core/src/main/scala/kafka/javaapi/Implicits.scala
<https://reviews.apache.org/r/14013/#comment50699>

    Could you please add a comment above this API explaining why we need to do this ? The same one you have in ByteBufferMessageSet.scala

core/src/main/scala/kafka/utils/Pool.scala
<https://reviews.apache.org/r/14013/#comment50700>

    In all other places, we have limited the scope of the JavaConversions import. Could we also do the same here?

project/Build.scala
<https://reviews.apache.org/r/14013/#comment50701>

    This is a cool hack. I think we can get rid of this only if/when we drop support for Scala 2.8.x.
- Neha Narkhede
On Sept. 7, 2013, 11:35 p.m., Christopher Freeman wrote: