Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka, mail # dev - [jira] [Commented] (KAFKA-943) Move all configuration key string to constants


+
Sam Meder 2013-07-03, 16:14
+
Sam Meder 2013-07-08, 06:06
Copy link to this message
-
[jira] [Commented] (KAFKA-943) Move all configuration key string to constants
"Jay Kreps 2013-07-11, 21:51

    [ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706288#comment-13706288 ]

Jay Kreps commented on KAFKA-943:
---------------------------------

I cleaned up the bad config strings I saw in our example server configs as part of KAFKA-718.
                
> Move all configuration key string to constants
> ----------------------------------------------
>
>                 Key: KAFKA-943
>                 URL: https://issues.apache.org/jira/browse/KAFKA-943
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config
>    Affects Versions: 0.8
>            Reporter: Sam Meder
>         Attachments: configConstants.patch
>
>
> The current code base has configuration key strings duplicated all over the place. They show up in the actual *Config classes, a lot of tests, command line utilities and other examples. This makes changes hard and error prone. DRY...
> The attached patch moves these configuration keys to constants and replaces their usage with a reference to the constant. It also cleans up a few old properties and a few misconfigured tests. I've admittedly not written a whole lot of Scala, so there may be some improvements that can be made, in particular I am not sure I chose the best strategy for keys needed by the SyncProducerConfigShared trait (or traits in general).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira