Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 22309: Patch for KAFKA-1298


Copy link to this message
-
Re: Review Request 22309: Patch for KAFKA-1298

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22309/

(Updated June 10, 2014, 12:20 a.m.)
Review request for kafka.
Bugs: KAFKA-1298
    https://issues.apache.org/jira/browse/KAFKA-1298
Repository: kafka
Description (updated)

KAFKA-1298. Controlled shutdown tool doesn't seem to work out of the box. Added a option to disable controlled shutdown in createBrokerConfig. Modified unit tests to disable controlled shutdown if replicationFactor is more than 1.
Diffs (updated)

  core/src/main/scala/kafka/controller/KafkaController.scala e776423b8a38da6f08b2262c8141abf2064d37d2
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala cd4ca2fa77763b090c6ad4ba4a5d46a6a8b76698
  core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 3c2bf36276d5079f352a77238fbd8030fe9448b7
  core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala fcd5eee09fc1831e7fac4c3f1151e9708dc6f5f1
  core/src/test/scala/unit/kafka/admin/AdminTest.scala 4f6ddca7eb64279350f1aa8824e2dbde44937072
  core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 1b3c04e051e929be80764f061f940c3cf6abe87b
  core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala 5eee08a01101ac1bbc1fd3d911051369955d20e1
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala b61c0b86c825f312ac34c7b630894d614861bcd2
  core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 0dec9ec7e8d68684f268098858a912e8f8932e6e
  core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 25dffcf706704a9e268f5f5f7f8882074d094e3e
  core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala b349fce21e7c33cb5bd9ac80cce0b23c31e87525
  core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 3e0bc189df3af33bd2a0c8336c6d4e1681c6d01a
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 4da0f2c245f75ff0dcab4ecf0af085ab9f8da1bb

Diff: https://reviews.apache.org/r/22309/diff/
Testing
Thanks,

Sriharsha Chintalapani