Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka, mail # dev - Review Request 15711: Patch for KAFKA-930


+
Sriram Subramanian 2013-11-20, 01:19
+
Sriram Subramanian 2013-11-20, 01:37
+
Sriram Subramanian 2013-11-20, 01:38
+
Joel Koshy 2013-11-21, 02:43
Copy link to this message
-
Re: Review Request 15711: Patch for KAFKA-930
Sriram Subramanian 2013-11-21, 17:42


> On Nov. 21, 2013, 2:43 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/controller/KafkaController.scala, line 944
> > <https://reviews.apache.org/r/15711/diff/3/?file=388714#file388714line944>
> >
> >     Any reason to not call onPreferredReplicaElection on the entire set of partitions (instead of one at a time). Doing it all at once within the controller context lock would also prevent a concurrent preferred replica election tool from proceeding into onPreferredReplicaElection (although if this feature is turned on you wouldn't need to use the command-line tool anyway).

We want to keep the locking fine grained to avoid zk related bug where a watcher trigger gets missed when the operation takes a long time.
- Sriram
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15711/#review29203
-----------------------------------------------------------
On Nov. 21, 2013, 5:42 p.m., Sriram Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15711/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 5:42 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-930
>     https://issues.apache.org/jira/browse/KAFKA-930
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> commit missing code
>
>
> some more changes
>
>
> fix merge conflicts
>
>
> Add auto leader rebalance support
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
> Conflicts:
> core/src/main/scala/kafka/admin/AdminUtils.scala
> core/src/main/scala/kafka/admin/TopicCommand.scala
>
> change comments
>
>
> commit the remaining changes
>
>
> Move AddPartitions into TopicCommand
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>   core/src/main/scala/kafka/server/KafkaConfig.scala b324344d0a383398db8bfe2cbeec2c1378fe13c9
>
> Diff: https://reviews.apache.org/r/15711/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriram Subramanian
>
>
 
+
Jun Rao 2013-11-20, 18:30
+
Sriram Subramanian 2013-11-20, 20:27
+
Jun Rao 2013-11-21, 17:22
+
Sriram Subramanian 2013-11-21, 17:42
+
Sriram Subramanian 2013-11-21, 17:42
+
Jun Rao 2013-11-21, 18:12
+
Neha Narkhede 2013-12-02, 18:06
+
Neha Narkhede 2013-12-02, 18:23
+
Jun Rao 2013-12-05, 16:11
+
Jun Rao 2013-12-05, 16:19
+
Sriram Subramanian 2013-12-10, 06:51
+
Sriram Subramanian 2013-12-10, 06:52
+
Neha Narkhede 2013-12-12, 00:17
+
Sriram Subramanian 2013-12-20, 19:24
+
Neha Narkhede 2013-12-20, 20:04
+
Sriram Subramanian 2013-12-20, 20:09
+
Sriram Subramanian 2013-12-20, 19:13
+
Sriram Subramanian 2013-12-20, 19:23
+
Neha Narkhede 2013-12-20, 20:51
+
Jun Rao 2013-12-23, 19:54
+
Jun Rao 2013-12-23, 20:00
+
Sriram Subramanian 2014-01-27, 21:28
+
Jun Rao 2014-01-29, 16:33
+
Neha Narkhede 2014-01-29, 17:38
+
Sriram Subramanian 2014-02-24, 09:59
+
Jun Rao 2014-02-24, 16:15
+
Sriram Subramanian 2013-11-21, 17:42
+
Sriram Subramanian 2013-11-21, 17:44