Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 17921: Misc fixes for perf tools.


Copy link to this message
-
Re: Review Request 17921: Misc fixes for perf tools.

Yeah I made another, but since you commented on this one, I'll review here.

The problem is that when testing small messages (say 10 bytes), this was adding 19 extra bytes. Since we are network bound for many of the tests this is quite significant when we send one request per message.

I don't think we should hard code the version number. It will be the 1.0 producer soon enough... :-)

Basically this is meant as a short term fix for the next few releases while we maintain both clients so I think "new producer" should be ambiguous in that timeframe.

Same as the other case, since this is a performance test adding 19 bytes to each messages is pretty significant when you test 10 byte messages. Do we really need it?

I don't think we should hard code the version number. It will be the 1.0 producer soon enough... :-)

Basically this is meant as a short term fix for the next few releases while we maintain both clients so I think "new producer" should be ambiguous in that timeframe.

Yes, will do.

Yes, the current producer test is too messed up to be trusted for performance testing. I don't believe anyone has actually run it through a profiler. It would be good to post mortum how that was allowed to happen but in the mean time I need this one.

My hope was to get the new producer stable and then go back and clean up the existing performance test. That is harder than it sounds because it has become totally coupled to the integration testing in terms of output.

Cool, I'll remove it.
- Jay
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17921/#review34135
On Feb. 10, 2014, 9:49 p.m., Jay Kreps wrote: