Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 14730: KAFKA-1001 V3


Copy link to this message
-
Re: Review Request 14730: KAFKA-1001 v4

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14730/#review27677

core/src/main/scala/kafka/server/AbstractFetcherManager.scala
<https://reviews.apache.org/r/14730/#comment53753>

    I think it's simpler to use mapLock for the whole method. It also reduces the locking overhead.

core/src/main/scala/kafka/server/AbstractFetcherThread.scala
<https://reviews.apache.org/r/14730/#comment53757>

    

core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/14730/#comment53744>

    catched ==> caught

core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/14730/#comment53748>

    Ditto as above.
- Jun Rao
On Oct. 28, 2013, 10:13 p.m., Guozhang Wang wrote: