Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments


Copy link to this message
-
Re: Review Request 15805: KAFKA-1140.v2: addressed Jun's comments

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15805/#review29438
Thinking about this a bit more. It seems that a better approach is to move the decoding into MessageAndMetadata. We define two methods key() and message() that do the decoding and throw a RuntimeException back to the caller if decoding fails. This way, the client can still get the metadata (offset, partitionId, etc) associated with a message even when decoding fails.

- Jun Rao
On Nov. 25, 2013, 8:55 p.m., Guozhang Wang wrote: