Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 21899: Patch for KAFKA-1382


Copy link to this message
-
Re: Review Request 21899: Patch for KAFKA-1382

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21899/#review45499
Thanks for the patch. Looks good to me. Just some minor comments below.
core/src/main/scala/kafka/cluster/Partition.scala
<https://reviews.apache.org/r/21899/#comment80352>

    Could we still keep this method instead of duplicating the code in both callers?

core/src/main/scala/kafka/utils/ReplicationUtils.scala
<https://reviews.apache.org/r/21899/#comment80353>

    Could we rename newLeader to expectedLeader?

core/src/main/scala/kafka/utils/ZkUtils.scala
<https://reviews.apache.org/r/21899/#comment80351>

    the write indeed have => the previous write has indeed
- Jun Rao
On June 11, 2014, 4:37 p.m., Sriharsha Chintalapani wrote: