Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 21899: Patch for KAFKA-1382

Copy link to this message
Re: Review Request 21899: Patch for KAFKA-1382

This is an automatically generated e-mail. To reply, visit:
Thanks for the patch. Looks good to me. Just some minor comments below.

    Could we still keep this method instead of duplicating the code in both callers?


    Could we rename newLeader to expectedLeader?


    the write indeed have => the previous write has indeed
- Jun Rao
On June 11, 2014, 4:37 p.m., Sriharsha Chintalapani wrote: