Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka, mail # dev - [jira] [Updated] (KAFKA-322) Remove one-off Send objects


Copy link to this message
-
[jira] [Updated] (KAFKA-322) Remove one-off Send objects
"Neha Narkhede 2014-02-01, 20:24

     [ https://issues.apache.org/jira/browse/KAFKA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-322:
--------------------------------

    Fix Version/s:     (was: 0.8.1)
                   0.9.0

> Remove one-off Send objects
> ---------------------------
>
>                 Key: KAFKA-322
>                 URL: https://issues.apache.org/jira/browse/KAFKA-322
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.0
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>            Priority: Minor
>              Labels: replication
>             Fix For: 0.9.0
>
>
> We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:
> ProducerResponseSend.scala
> It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.
> I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)