Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka >> mail # dev >> Review Request 20380: Fix KAFKA-1395


+
Guozhang Wang 2014-04-15, 22:07
+
Jun Rao 2014-04-16, 15:14
+
Neha Narkhede 2014-04-21, 22:12
+
Jun Rao 2014-04-22, 22:00
Copy link to this message
-
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/#review41472
 Great cleanup patch! Some minor comments.

1. TestUtils.createProducer: Could we keep the props parameter and treat it as the list of properties that we want to override?

2. Unused imports in ServerShutdownTest and LogRecoveryTest.

- Jun Rao
On April 24, 2014, 11:22 p.m., Guozhang Wang wrote:
 
+
Jun Rao 2014-04-25, 20:40