Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka, mail # dev - Review Request 14554: Move AddPartitions into TopicCommand in trunk


Copy link to this message
-
Re: Review Request 14554: Move AddPartitions into TopicCommand in trunk
Sriram Subramanian 2013-10-09, 17:56


> On Oct. 9, 2013, 5:31 p.m., Guozhang Wang wrote:
> > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala, line 122
> > <https://reviews.apache.org/r/14554/diff/1/?file=362781#file362781line122>
> >
> >     Why need to increment the added # partitions by 1 here?

The addPartitions input is the total number of partitions now.
- Sriram
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14554/#review26823
-----------------------------------------------------------
On Oct. 9, 2013, 6:48 a.m., Sriram Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14554/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2013, 6:48 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1052
>     https://issues.apache.org/jira/browse/KAFKA-1052
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Move AddPartitions into TopicCommand
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/admin/AddPartitionsCommand.scala c74d9c224565d475d4104467ba36c0a287b68239
>   core/src/main/scala/kafka/admin/AdminUtils.scala 6560fc668e8b8feedc1e3f63c11aac2ff370c8d0
>   core/src/main/scala/kafka/admin/TopicCommand.scala 06bbd37a5af1ea5bd5f6c42cb9063cc7d6fd381b
>   core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 09254ccac2a4d5885a372f1f21b0a5813a930ded
>
> Diff: https://reviews.apache.org/r/14554/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriram Subramanian
>
>