Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 17263: New producer for Kafka.


Copy link to this message
-
Re: Review Request 17263: New producer for Kafka.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17263/#review32802
-----------------------------------------------------------

clients/src/main/java/kafka/common/PartitionInfo.java
<https://reviews.apache.org/r/17263/#comment61801>

    Why not use TopicPartition class here?

clients/src/main/java/kafka/common/config/ConfigDef.java
<https://reviews.apache.org/r/17263/#comment61802>

    Verifiable properties also specifies if a default value was overriden. This is useful when debugging. Could we have that here?

clients/src/main/java/kafka/common/metrics/CompoundStat.java
<https://reviews.apache.org/r/17263/#comment61803>

    Some documentation on the metrics stuff would be useful

clients/src/main/java/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/17263/#comment61804>

    Should this be unmodifiable?

clients/src/main/java/kafka/common/network/NetworkSend.java
<https://reviews.apache.org/r/17263/#comment61806>

    It would be worth adding a comment on why this extends ByteBufferSend. All network sends are materialized into buffer first before being sent. Have you thought of avoiding that on send?

clients/src/main/java/kafka/common/network/NetworkSend.java
<https://reviews.apache.org/r/17263/#comment61805>

    Why do copy here? Instead why not maintain the buffers as a list and add size as the first buffer to it?

clients/src/main/java/kafka/common/network/Selector.java
<https://reviews.apache.org/r/17263/#comment61807>

    Typo. Not an interface.

clients/src/main/java/kafka/common/network/Selector.java
<https://reviews.apache.org/r/17263/#comment61808>

    Do you really want to return the actual modifiable lists here?

clients/src/main/java/kafka/common/protocol/Protocol.java
<https://reviews.apache.org/r/17263/#comment61809>

    Do you want error code in the response header?
- Sriram Subramanian
On Jan. 23, 2014, 8:54 p.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17263/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2014, 8:54 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1227
>     https://issues.apache.org/jira/browse/KAFKA-1227
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1227 New producer!
>
>
> Diffs
> -----
>
>   clients/build.sbt PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/BufferExhaustedException.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/Callback.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/DefaultPartitioner.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/KafkaProducer.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/MockProducer.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/Partitioner.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/Producer.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/ProducerConfig.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/ProducerRecord.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/RecordSend.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/BufferPool.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/Metadata.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/ProduceRequestResult.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/RecordAccumulator.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/RecordBatch.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/Sender.java PRE-CREATION
>   clients/src/main/java/kafka/clients/tools/ProducerPerformance.java PRE-CREATION