Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Kafka >> mail # dev >> Review Request 17688: API refactoring for new producer


Copy link to this message
-
Re: Review Request 17688: API refactoring for new producer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17688/#review33556
-----------------------------------------------------------

Ship it!

clients/src/main/java/kafka/clients/producer/Callback.java
<https://reviews.apache.org/r/17688/#comment63077>

    I think Jun suggested this and I agree. We have a callback on the producer, one on the controller and possibly another one on the consumer. How do you feel about renaming this to something that will make it clear that it belongs to the producer, eg ProducerCallback?

clients/src/main/java/kafka/clients/producer/internals/Partitioner.java
<https://reviews.apache.org/r/17688/#comment63078>

    
- Neha Narkhede
On Feb. 4, 2014, 1:41 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17688/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 1:41 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1227
>     https://issues.apache.org/jira/browse/KAFKA-1227
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Implement a few of the API suggestions from the mailing list.
>
>
> Diffs
> -----
>
>   clients/src/main/java/kafka/clients/producer/Callback.java 47e5af31515e6f9879f5c24749f3a795d30e4192
>   clients/src/main/java/kafka/clients/producer/DefaultPartitioner.java b82fcfbe1a00fed1cfe2bc9ba72e1d6e2b5f767b
>   clients/src/main/java/kafka/clients/producer/KafkaProducer.java 58eee0c3236179ddf86e9d04848a29caf050eabc
>   clients/src/main/java/kafka/clients/producer/MockProducer.java 2ea2030dc2b3f052f490f1c66adccfcab21619de
>   clients/src/main/java/kafka/clients/producer/Partitioner.java 1b8e51f6aef0e15c81668514623f44d58ea0e9d5
>   clients/src/main/java/kafka/clients/producer/Producer.java 6ba66339d741986faa4831e65082b4af683180c1
>   clients/src/main/java/kafka/clients/producer/ProducerConfig.java 97582933c8d7de31fdfabcfb1540a7941ae254c4
>   clients/src/main/java/kafka/clients/producer/ProducerRecord.java 5fddbef92e542b3cb830df74e88fd8ae3f808dee
>   clients/src/main/java/kafka/clients/producer/RecordMetadata.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/RecordSend.java 1883dabc3a9830d362dc865112f20910881f9354
>   clients/src/main/java/kafka/clients/producer/internals/FutureRecordMetadata.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/Partitioner.java PRE-CREATION
>   clients/src/main/java/kafka/clients/producer/internals/ProduceRequestResult.java 1049b61625d486f48194370178486cc9f08e1605
>   clients/src/main/java/kafka/clients/producer/internals/RecordAccumulator.java a2b536c3447e69588fcd6b9c5f94df3806d330f9
>   clients/src/main/java/kafka/clients/producer/internals/RecordBatch.java 4a536a29408f898736fa3d08959adf42d4a53973
>   clients/src/main/java/kafka/clients/producer/internals/Sender.java effeb9c19e2dd004e6191956d4bf26da618a134b
>   clients/src/main/java/kafka/clients/tools/ProducerPerformance.java 7331b73a060465bc53d2af98ac58ba1f1579fd21
>   clients/src/main/java/kafka/common/ByteSerialization.java eca69f187537b692f7ec9c634a6a2a130a6246d0
>   clients/src/main/java/kafka/common/Cluster.java d0acd8d2801420d6c411e1113ad1451213843979
>   clients/src/main/java/kafka/common/Deserializer.java ad2e78466a3de921c476838c5b147bb34a2c3fe8
>   clients/src/main/java/kafka/common/PartitionInfo.java f3f08dd30d2fa6cd236d9afa66791fe752c57b6e
>   clients/src/main/java/kafka/common/Serializer.java 63353d8274497ba0a2aa52b13c9ace4671fac9cb
>   clients/src/main/java/kafka/common/StringSerialization.java c0ed5ca20e8685f16e593ac8f670d8d098e32607
>   clients/src/main/java/kafka/common/errors/CorruptMessageException.java faf62340178e74c1590539961dbbda4e8dd5152f
>   clients/src/main/java/kafka/common/errors/MessageTooLargeException.java 7417906fd9faa18783f7c2e0a17576496539ddb9