Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Kafka, mail # dev - Review Request 15953: Patch for KAFKA-1134


+
Guozhang Wang 2013-12-03, 00:58
Copy link to this message
-
Re: Review Request 15953: Patch for KAFKA-1134
Neha Narkhede 2013-12-03, 01:30

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15953/#review29636
-----------------------------------------------------------

core/src/main/scala/kafka/controller/KafkaController.scala
<https://reviews.apache.org/r/15953/#comment57045>

    it seems that onControllerFailover is already protected by the controllerLock. The elect() API of ZookeeperLeaderElector is invoked in 3 places and each of those acquires the controllerLock
- Neha Narkhede
On Dec. 3, 2013, 12:58 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15953/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 12:58 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1134
>     https://issues.apache.org/jira/browse/KAFKA-1134
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1134.v1
>
>
> Diffs
> -----
>
>   core/src/main/scala/kafka/controller/KafkaController.scala 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3
>
> Diff: https://reviews.apache.org/r/15953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
 
+
Neha Narkhede 2013-12-09, 21:58
+
Guozhang Wang 2013-12-09, 23:01
+
Neha Narkhede 2013-12-10, 23:48